feat: add an option to send custom gas limit when making transfers #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/custom-gas-limit
…t/custom-gas-limit
…t/custom-gas-limit
helciofranco
requested review from
luizstacio,
pedronauck and
LuizAsFight
as code owners
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 62.16% | 3234/5203 |
| 🔴 | Branches | 41.33% | 634/1534 |
| 🔴 | Functions | 47.02% | 686/1459 |
| 🟡 | Lines | 62.71% | 3116/4969 |
Test suite run success
243 tests passing in 71 suites.
Report generated by 🧪jest coverage report action from a1edfa5
LuizAsFight
requested changes
May 28, 2024
|
if you want, you can also include #1295 in this PR. or in a next PR would be fine also. up to you |
…t/custom-gas-limit
…t/custom-gas-limit
LuizAsFight
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Fee plus tip confusing #1295
Closes update ts-sdk and include gasLimit #1305
Closes Fee plus tip confusing #1295
Closes Can enter multiple leading 0s in the tip field #1294
Closes Backspace takes the field back to 0 #1293
Add custom gas limit input when sending transfers
Upgrade
fuelsto latestImprove UX when typing tip and gas limit
Screen.Recording.2024-05-29.at.12.14.54.mov